Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 16 #58

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Update to Angular 16 #58

merged 6 commits into from
Jan 16, 2024

Conversation

samiv22
Copy link
Contributor

@samiv22 samiv22 commented Jan 16, 2024

Hi,

I've found this package to be most helpful in my current project but as I started to update my Angular-version in my project I noticed that this does not support >Angular 15.

I've tried to make this now work with Angular 16, but this is my first ever contribution so please provide feedback if I missed anything!

  • Updated Changelog to include version 9 and 10 changes
  • Added compatibility section to readme.md
  • Fixed couple of errors my IDE (PHPStorm) gave
  • Updated Angular version from 15->16
  • Checked that all tests pass. 1 test is skipped.

Will be creating also Angular version 17 update if this goes well :)

Br, Sami

Copy link
Owner

@davidwalschots davidwalschots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! A few comments, but nothing major.

projects/test-app/src/app/app.component.ts Outdated Show resolved Hide resolved
projects/test-app/src/app/app.component.ts Outdated Show resolved Hide resolved
projects/test-app/src/app/app.module.ts Outdated Show resolved Hide resolved
projects/angular-reactive-validation/package.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@davidwalschots davidwalschots merged commit 568ea58 into davidwalschots:main Jan 16, 2024
@davidwalschots
Copy link
Owner

I'll release an npm package of this version somewhere tomorrow. Should you be done with the Angular 17 PR by that time I'll also release that one. Thanks again for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants