Pass Trigger Configurations to CodeDeploy #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgf
requested changes
Jan 3, 2019
There was a problem hiding this comment.
Happy new year to you too! It does look good, although the build is failing. It would be cool if you could add some integration tests as well, to do so take a look at the fixtures/ folder. You only need to include three new JSON files:
inputis how the CloudFormation template looks initiallyservicecontains the service's settings, such as the plugin configuration. It's basically a JSON representation ofserverless.ymloutputis how the CloudFormation template should be after running the plugin with the provided settings
nason
force-pushed
the
add-trigger-configuration
branch
from
0464dfe
to
1ccacf0
Compare
|
👍
|
|
Hey @davidgf hows this looking now? |
|
I looks really good, thank you very much for contributing! I'll release a new package version asap |
davidgf
approved these changes
Jan 14, 2019
samcon
pushed a commit
to samcon/serverless-plugin-canary-deployments
that referenced
this pull request
Sep 6, 2020
* Pass Trigger Configurations to CodeDeploy * Add fixtures for TriggerConfigurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44
Happy new year! How does this look @davidgf?