feat: generate deployment group name #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchungy
commented
Aug 30, 2021
| @@ -2,12 +2,12 @@ const aws = require('aws-sdk') | |||
| const codedeploy = new aws.CodeDeploy({ apiVersion: '2014-10-06' }) | |||
|
|
|||
| module.exports.pre = (event, context, callback) => { | |||
| var deploymentId = event.DeploymentId | |||
| var lifecycleEventHookExecutionId = event.LifecycleEventHookExecutionId | |||
| const deploymentId = event.DeploymentId | |||
There was a problem hiding this comment.
ran standard --fix due to lint issues
| @@ -1,19 +1,11055 @@ | |||
| { | |||
| "name": "serverless-plugin-canary-deployments", | |||
| "version": "0.4.8", | |||
| "lockfileVersion": 1, | |||
| "version": "0.6.0", | |||
There was a problem hiding this comment.
Ran npm audit fix since it was yelling at me.
|
@davidgf could you take a look at this one? :) |
|
Thank you very much for your contribution! |
Merged
|
Thank you so much for this @samchungy! 🎉 🙌 |
|
Finally Fixed the issue of Circular Dependency... Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
${stackName}-${logicalId}to avoid a circular dependency when used with the aws-alerts plugin.npm audit fixResolves #127
Resolves #114
Types of changes
What types of changes does your code introduce to the plugin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Ran on sls-canary-example repo
Before:
After:
