Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project files improvement and more target-frameworks #42

Merged
merged 5 commits into from
Mar 11, 2020

Conversation

moien007
Copy link
Contributor

Hi,

This PR contains the following changes:

  • Improvement and simplification of projects files
  • Updating NuGet package references to the latest available
  • Support for .NET Framework 4.8
  • Support for .NET Standard 2.1
  • Using BitOperations class for .NET Core 3.1 (The explanation)

These changes are not what I supposed to make but I have to commit that I may not be able to solve the two issues #40 and #41 at all due to my lack of knowledge of the NaCl itself, sorry for that.

Regards.

Copy link
Owner

@daviddesmet daviddesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've added some comments in the code before merging your changes.
Could you please take a look into them? For #40 and #41, I will take a look later. I still have pending a push for #32

src/NaCl.Core/NaCl.Core.csproj Show resolved Hide resolved
src/NaCl.Core/NaCl.Core.csproj Show resolved Hide resolved
src/NaCl.Core.Tests/NaCl.Core.Tests.csproj Outdated Show resolved Hide resolved
src/NaCl.Core/NaCl.Core.csproj Show resolved Hide resolved
@moien007
Copy link
Contributor Author

I'm a noob in git. I addressed your requested changes by pushing this commit, is that how I should have done that?

@daviddesmet
Copy link
Owner

I'm a noob in git. I addressed your requested changes by pushing this commit, is that how I should have done that?

No worries, you did it right! We all started as noob in git. 😉
Will merge your PR and address the CI Pipeline later since it's giving some errors.

@daviddesmet daviddesmet merged commit a89e1bb into daviddesmet:master Mar 11, 2020
@daviddesmet
Copy link
Owner

@moien007 The changes will be pushed later to nuget.org but in case you feel eager to try it now, you can grab them from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants