Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluto support #90

Open
fonsp opened this issue Apr 29, 2021 · 8 comments
Open

Pluto support #90

fonsp opened this issue Apr 29, 2021 · 8 comments

Comments

@fonsp
Copy link

fonsp commented Apr 29, 2021

Hi!

It looks like this package uses an internal API, making it incompatible with https://github.com/fonsp/Pluto.jl and other custom logging environemnts.

See fonsp/Pluto.jl#1121

-fons

@PavanChaggar
Copy link
Contributor

What's the status on this? I'm still getting the error:

gmm
type PlutoLogger has no field min_level
getproperty(::Main.PlutoRunner.PlutoLogger, ::Symbol)@Base.jl:42
var"#GMMk#11"(::Symbol, ::Int64, ::Int64, ::Int64, ::typeof(GaussianMixtures.GMMk), ::Int64, ::Matrix{Float64})@train.jl:103
#GMM#[email protected]:37[inlined]
[email protected]:32[inlined]
top-level scope@[Local: 1](http:https://localhost:1234/edit?id=eab1dbc0-9e53-11ec-1b37-75a82665b36b#)[inlined]

I saw there was a PR that was not merged. If someone is able to advise on how to fix I can submit another PR.

@PavanChaggar
Copy link
Contributor

I've fixed it (using the same changes as in the previous pr) and am just using a dev'd version of the package for now. What was the reason the pr was not merged?

@davidavdav
Copy link
Owner

Hello,

I am not sure. Somebody closed that PR, it wasn't me. Usually a PR has a bit more explanation on what is going on, and there should be some evidence that the normal tests are passed.

Probably automatic testing is broken at the moment, this package needs to move from travis to a github action.

@PavanChaggar
Copy link
Contributor

Hey! Ok. I can open up another PR with the fixes and a bit more explanation.

@PavanChaggar
Copy link
Contributor

opened #96 to address this. Let me know if I can do anything else.

@PavanChaggar
Copy link
Contributor

Thanks for merging #96 :) Do you know roughly when the next release will be?

@davidavdav
Copy link
Owner

Sorry, I normally release immediately after a PR that passes the test. There should be 0.3.7 out soon.

@davidavdav
Copy link
Owner

davidavdav commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants