Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow /random endpoint to filter by search request #11

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

davemachado
Copy link
Owner

Fixes issue #10. Along with allowing the /random endpoint to accept a
search request filter, we have done some unit test refactoring.

Fixes issue #10. Along with allowing the /random endpoint to accept a
search request filter, we have done some unit test refactoring.
@davemachado davemachado added the enhancement New feature or request label Feb 4, 2019
@codecov-io
Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #11 into master will increase coverage by 3.45%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   27.95%   31.41%   +3.45%     
==========================================
  Files           4        4              
  Lines         186      191       +5     
==========================================
+ Hits           52       60       +8     
+ Misses        130      123       -7     
- Partials        4        8       +4
Impacted Files Coverage Δ
handlers.go 61.11% <40%> (+5.93%) ⬆️
util.go 72.97% <77.77%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d959f...29e35b0. Read the comment docs.

Add Parameters to the /random endpoint description.
@davemachado davemachado merged commit a5d59ff into master Feb 4, 2019
@davemachado davemachado deleted the feature/random-accept-search-request branch February 4, 2019 03:13
@ElWeroRanchero ElWeroRanchero mentioned this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants