Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import syntax and ckanserviceprovider version #125

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

categulario
Copy link
Contributor

Hi everyone, it's me again!

So I was trying to build and run the container for datapusher-plus and it failed in two ways:

  • first it complained at run time about the import syntax for the internal config module from main. Indeed: config is not a globally registered module and therefore cannot be imported as config unless $CWD is datapusher, which I suspect most of the time is not. This PR fixes that. The fix assumes that this is installed as a python package, probably via pip install -e or similar, which is what the readme says anyways. I'm actually wondering how this worked to begin with.
  • then it complained about some flask import that doesn't exist in the package flask-login. It turns out this is related to the release of flask 3 and it is fixed in ckanserviceprovider 1.2.0 (see ckan/ckan-service-provider@b467d44).

Thanks!

Abraham Toriz added 2 commits October 24, 2023 11:40
this fixes a problem with an unsupported flask version of 3.0.0 that was
solved in the commit:

ckan/ckan-service-provider@b467d44
@categulario
Copy link
Contributor Author

This fixes #76

@jqnatividad jqnatividad merged commit 7bf1302 into dathere:master Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants