Fix signed/unsigned mismatch #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following warnings from MSVC:
warning C4245: 'initializing': conversion from 'int' to 'datastax::StringRef::size_type', signed/unsigned mismatch
warning C4245: '=': conversion from 'int' to 'DWORD', signed/unsigned mismatch
|
Thanks for the PR @SeverinLeonhardt! These seem like pretty nice improvements; I had originally wondered about just casting the npos assignment but after thinking about it a bit I think your solution is the better option. As discussed on the other PR I'm going to hold on merging this until we can get our build infrastructure issues sorted out. |
|
Per comments on #535 merging this now so that it can be included in upcoming release. Thanks (again) @SeverinLeonhardt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following warnings from MSVC: