Fix: Only using a single resolved IP when connecting with hostname #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SocketConnector::resolved_address_offset_` is never incremented because the first parameter was wrong. Also, this adds a default filter to for resolver hints to prevent duplicates in the resolved IPs.
simonebaracchi
pushed a commit
to cloudian/cpp-driver
that referenced
this pull request
Jan 28, 2021
…atastax#488) `SocketConnector::resolved_address_offset_` is never incremented because the first parameter was wrong. Also, this adds a default filter to for resolver hints to prevent duplicates in the resolved IPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketConnector::resolved_address_offset_is never incremented becausethe first parameter was wrong. Also, this adds a default filter for
resolver hints to prevent duplicates in the resolved IPs.