Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Reject invalid project URLs #141

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Conversation

bpoldrack
Copy link
Member

Closes #139

Those are invalid OSF project URLs.

(Closes datalad#139)
@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #141 (73e3af4) into master (6d63ff8) will increase coverage by 0.15%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   15.11%   15.27%   +0.15%     
==========================================
  Files          40       40              
  Lines        2540     2547       +7     
==========================================
+ Hits          384      389       +5     
- Misses       2156     2158       +2     
Impacted Files Coverage Δ
datalad_osf/git_remote.py 0.00% <0.00%> (ø)
datalad_osf/tests/test_public.py 97.14% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d63ff8...73e3af4. Read the comment docs.

@bpoldrack
Copy link
Member Author

I assume the github action for windows can be disabled with windows being tested on appveyor or is there a reason for it still lingering around, @mih?

@mih
Copy link
Member

mih commented Jan 29, 2021

I assume the github action for windows can be disabled with windows being tested on appveyor or is there a reason for it still lingering around, @mih?

It can go AFAICS

datalad_osf/git_remote.py Outdated Show resolved Hide resolved
A path component consisting solely of a '/' is still fine.
@bpoldrack bpoldrack merged commit 5cae706 into datalad:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git-remote helper ignores path in URL
3 participants