Update logger #1044
Draft
Update logger #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jverswijver From our prior discussion, the largest issue I see here is that if we are properly addition |
|
Yes, we should try to look for the config and if it is there we should load the log level for the user when we create the logger. Except of they have the log level set in their env which should take priority. |
| @@ -248,6 +248,9 @@ def __setitem__(self, key, value): | |||
| self._conf[key] = value | |||
| else: | |||
| raise DataJointError("Validator for {0:s} did not pass".format(key)) | |||
| valid_logging_levels = ["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"] | |||
| if "loglevel" in key and value in valid_logging_levels: | |||
There was a problem hiding this comment.
Suggested change
| if "loglevel" in key and value in valid_logging_levels: | |
| if "loglevel" == key and value in valid_logging_levels: |
There was a problem hiding this comment.
should probably raise an error if value is not valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small changes to logging behavior:
dj.configis updated