feat(entity-client): enable client side cache for entity-client and usage-client #8877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
david-leifker
commented
Sep 21, 2023
| private RestliEntityClient _entityClient; | ||
| private EntityRegistry _entityRegistry; | ||
|
|
||
| public final static ImmutableSet<String> EXCLUDED_ASPECTS = ImmutableSet.<String>builder() |
There was a problem hiding this comment.
The hydrator is used when writing to datahub usage events. Lineage is known to exceed ES document sizes and is of questionable value for analytics. Excluding various lineage aspects from the DUE entities. The entities themselves are still recorded.
There was a problem hiding this comment.
Can we use the Constants.*_ASPECT_NAME static strings here?
david-leifker
commented
Sep 21, 2023
| @@ -0,0 +1,134 @@ | |||
| package com.linkedin.common.client; | |||
There was a problem hiding this comment.
This is the core logic, built on the available Caffeine cache.
metadata-service/configuration/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
RyanHolstien
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a client cache for entity-client, enabled on the system-entity-client specifically. Features include per aspect TTL, maximum size (roughly), and cache metrics.
This cache is particularly useful for caching the usage stats calls on search result pages and user information where for a given page load there are multiple calls to fetch the same information.
Checklist