Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/bigquery): Handle null view_definition; remove view definition hash ids #8747

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

asikowitz
Copy link
Collaborator

Have seen ingestions fail because view.view_definition is None. This somewhat awkwardly sets the type for snowflake too, but I don't see the harm in being a bit safer on this typing anyway

Second piece is follow-up as discussed in #8382 (comment)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 29, 2023
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question but otherwise lgtm

@@ -44,7 +44,7 @@ class BaseView:
comment: Optional[str]
created: Optional[datetime]
last_altered: Optional[datetime]
view_definition: str
view_definition: Optional[str]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when would this be null?

@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 29, 2023
@asikowitz asikowitz merged commit fa0c43c into datahub-project:master Aug 30, 2023
49 of 50 checks passed
@asikowitz asikowitz deleted the view-definition-optional branch August 30, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants