Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ingest/testing-utils): Add back delta info ignore path #8402

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

asikowitz
Copy link
Collaborator

For some reason, the custom operator doesn't seem to be working when running connector tests, resulting in the diffs printing AspectForDiff objects. I wasn't able to debug the custom operator, so I'm just adding the ignore path back to ignore the delta info object... It seemed to be working before, so I'd like to leave it in, e.g. if the error is due to a change by deepdiff -- it causes no harm.

I also add a custom repr method to AspectForDiff in case this happens again just to make the error messages a bit nicer, but we really shouldn't hit this.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from hsheth2 July 11, 2023 20:43
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 11, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jul 11, 2023
@asikowitz asikowitz merged commit 71f80b6 into datahub-project:master Jul 12, 2023
40 of 43 checks passed
@asikowitz asikowitz deleted the add-delta-ignore-path branch July 12, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants