Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ingest/airflow): Fix test for airflow 2.6.3 #8393

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

asikowitz
Copy link
Collaborator

Old date serialization broke new regex for run_id. Also swaps DummyOperator -> EmptyOperator as per deprecation message

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@@ -15,7 +15,7 @@
import pytest
from airflow.lineage import apply_lineage, prepare_lineage
from airflow.models import DAG, Connection, DagBag, DagRun, TaskInstance
from airflow.operators.dummy import DummyOperator
from airflow.operators.empty import EmptyOperator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EmptyOperator is airflow 2.3.x and newer, but we support down to airflow 2.2

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 11, 2023
@asikowitz asikowitz merged commit 759d0c8 into datahub-project:master Jul 11, 2023
41 of 44 checks passed
@asikowitz asikowitz deleted the airflow-ci-fix branch July 11, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants