test(ingest/minio): Configure delta lake minio tests for arm64 #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
reviewed
Jul 4, 2023
| chmod +x ./tests/integrations/delta_lake/minio/minio | ||
| nohup ./tests/integrations/delta_lake/minio/minio server ./tests/integrations/delta_lake/minio/data > temp.log 2>&1 & | ||
| echo $! > ./tests/integrations/delta_lake/minio/minio_pid.txt | ||
| if [[ $(uname -m) == 'arm64' && $(uname) == 'Darwin' ]]; then |
There was a problem hiding this comment.
Why we don't install with brew if the arch is Darwin and amd64?
FYI -> here is how we do brew install in the preflight script ->
https://github.com/datahub-project/datahub/blob/cfa864e4187b6f9adafd7e951294be8e6109d03d/metadata-ingestion/scripts/datahub_preflight.sh#L8C7-L8C7
There was a problem hiding this comment.
I was just trying to make work with arm macs. I don't really have a preference here
metadata-ingestion/tests/integration/delta_lake/minio/setup_minio.sh
Outdated
Show resolved
Hide resolved
…nio.sh Co-authored-by: Tamas Nemeth <[email protected]>
|
@asikowitz to update this to use docker instead of downloading binaries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces with docker container
Checklist