Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quickstart): use platform agnostic way to get folder #5400

Merged
merged 4 commits into from
Jul 15, 2022
Merged

fix(quickstart): use platform agnostic way to get folder #5400

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd7f4c2
fix(quickstart): use platform agnostic way to get folder
anshbansal Jul 15, 2022
a2b9e58
cleanup
anshbansal Jul 15, 2022
eee0102
turn into a constant
anshbansal Jul 15, 2022
c2a273a
cleanup
anshbansal Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@anshbansal
anshbansal committed Jul 15, 2022
commit a2b9e589f885a42806a6e3b1b60d962c36904f7a
1 change: 0 additions & 1 deletion metadata-ingestion/src/datahub/cli/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ def _get_default_quickstart_compose_file() -> Optional[str]:

def _attempt_stop(quickstart_compose_file: List[pathlib.Path]) -> None:
default_quickstart_compose_file = _get_default_quickstart_compose_file()
print(f"quickstart file is {default_quickstart_compose_file}")
compose_files_for_stopping = (
quickstart_compose_file
if quickstart_compose_file
Expand Down