Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): working mssql aliases #4523

Merged
merged 2 commits into from
Mar 30, 2022
Merged

fix(ingest): working mssql aliases #4523

merged 2 commits into from
Mar 30, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Mar 29, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@kevinhu kevinhu mentioned this pull request Mar 29, 2022
Closed
@github-actions
Copy link

Unit Test Results (build & test)

  93 files  ±0    93 suites  ±0   13m 9s ⏱️ - 7m 28s
680 tests ±0  621 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 5948bfd. ± Comparison against base commit df69e76.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 0m 33s ⏱️ +31s
   388 tests ±0     388 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 787 runs  ±0  1 756 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 5948bfd. ± Comparison against base commit df69e76.

shirshanka
shirshanka approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 1bad3c7 into datahub-project:master Mar 30, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@kevinhu @maggiehays
fix(ingest): mssql - support database_alias (datahub-project#4523)
ac1b628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka