Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): ignore custom connectors for Glue ingestion #3805

Merged
merged 4 commits into from
Jan 5, 2022
Merged

fix(ingest): ignore custom connectors for Glue ingestion #3805

merged 4 commits into from
Jan 5, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Dec 30, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 30, 2021 •
edited
Loading

Unit Test Results

     48 files  +  3       48 suites  +3   50m 25s ⏱️ + 8m 11s
   663 tests +16     611 ✔️ +16  52 💤 ±0  0 ❌ ±0 
1 467 runs  +14  1 393 ✔️ +  8  74 💤 +6  0 ❌ ±0 

Results for commit 0881db0. ± Comparison against base commit 450cdc1.

♻️ This comment has been updated with latest results.

@kevinhu kevinhu marked this pull request as ready for review December 30, 2021 04:10
shirshanka
shirshanka reviewed Jan 4, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/aws/glue.py Outdated
raise ValueError(f"Unrecognized Glue data object type: {node_args}")
if self.source_config.ignore_unsupported_connectors:

self.report.report_warning(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does report_warning create a possibility of the pipeline failing if pipeline warnings == failure setting is true?
Is that the default?

Copy link
Contributor Author

@kevinhu kevinhu Jan 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point – I'll use logging.info instead

shirshanka
shirshanka approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 5b36944 into datahub-project:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka