Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): sqlalchemy-snowflake dependency constraint #3078

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fix(ingest): sqlalchemy-snowflake dependency constraint #3078

merged 1 commit into from
Aug 11, 2021

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Aug 11, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@kevinhu kevinhu closed this Aug 11, 2021
@kevinhu kevinhu reopened this Aug 11, 2021
@kevinhu kevinhu marked this pull request as ready for review August 11, 2021 20:16
shirshanka
shirshanka approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit f642d6c into datahub-project:master Aug 11, 2021
rahulbsw pushed a commit to rahulbsw/datahub that referenced this pull request Sep 2, 2021
@kevinhu
fix(ingest): sqlalchemy-snowflake add constraints to make sure we don…
5b2917d 
…'t pull in 1.2.5 (datahub-project#3078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka