fix(metadata-io):Recently viewed, Recently Edited and Recently Searched section is missing in datahub home page

[siladitya2]

Issue:

We currently observe that the Recently Viewed and Recently Edited section is missing on datahub home page.
Also, Recently Searches section is missing on search bar

Root cause:

When the SearchRequest for Recently Viewed/Edited or Searched item is build then instead of considering the Session User,System User is used in the SearchRequest as actorUrn.

Example SearchRequest of Recently Viewed from my local debug log:

SearchRequest{searchType=QUERY_THEN_FETCH, indices=[datahub_usage_event], indicesOptions=IndicesOptions[ignore_unavailable=false, allow_no_indices=true, expand_wildcards_open=true, expand_wildcards_closed=false, expand_wildcards_hidden=false, allow_aliases_to_multiple_indices=true, forbid_closed_indices=true, ignore_aliases=false, ignore_throttled=true], routing='null', preference='null', requestCache=null, scroll=null, maxConcurrentShardRequests=0, batchedReduceSize=512, preFilterShardSize=null, allowPartialSearchResults=null, localClusterAlias=null, getOrCreateAbsoluteStartMillis=-1, ccsMinimizeRoundtrips=true, source={"size":0,"query":{"bool":{"must":[{"term":{"actorUrn.keyword":{"value":"urn:li:corpuser:__datahub_system","boost":1.0}}},{"term":{"type":{"value":"EntityViewEvent","boost":1.0}}}],"adjust_pure_negative":true,"boost":1.0}},"aggregations":{"entity":{"terms":{"field":"entityUrn.keyword","size":5,"min_doc_count":1,"shard_min_doc_count":0,"show_term_doc_count_error":false,"order":[{"last_viewed":"desc"},{"_key":"asc"}]},"aggregations":{"last_viewed":{"max":{"field":"timestamp"}}}}}}, cancelAfterTimeInterval=null, pipeline=null}

Response:
{"took":12,"timed_out":false,"_shards":{"total":1,"successful":1,"skipped":0,"failed":0},"hits":{"total":{"value":0,"relation":"eq"},"max_score":null,"hits":[]},"aggregations":{"sterms#entity":{"doc_count_error_upper_bound":0,"sum_other_doc_count":0,"buckets":[]}}}

If you observe the SearchRequest above, instead of using the Session User(urn:li:corpuser:[email protected]) it is building the SearchRequest with the System User: urn:li:corpuser:__datahub_system .
That's why the response of this SearchRequest does not contain any data.

Fix:
Use the user from the getSessionActorContext() while building the SearchRequest for Recently Viewed, Edited and Searched items.

Test result:
UI Screen shot from my local after applying the fix.

Note:
This issue could be fixed an alternate way like below(SpringQueryContext.java)

this.operationContext = OperationContext.asSession(systemOperationContext, authorizer, authentication, false);
but which seems to be a contradictory of this PR

@david-leifker could you please review and provide your thought on this?

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[david-leifker]

LGTM! Thanks!