Feat/update search pages #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only 12 vulnerabilities left !
…kempf57/udata-front into feat/update-search-pages
- mapToOption is now idempotent - allow minimumCharacterBeforeSuggest - remove noResultWaitingTyping
maudetes
approved these changes
May 23, 2022
There was a problem hiding this comment.
I think we're (almost) all good!
I've just added a minor wording detail.
We also had this point if you want to take a look. I think we can read the value the same way we read the value for facets facets.value = Object.fromEntries(params);.
maudetes
reviewed
May 23, 2022
…kempf57/udata-front into feat/update-search-pages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left to decide :
Close datagouv/data.gouv.fr#774
Close datagouv/data.gouv.fr#775
Close datagouv/data.gouv.fr#347
Close datagouv/data.gouv.fr#610