Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quality score warning to be hidden #414

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented May 21, 2024

This PR updates the non-inline version of the quality component in @datagouv/components. It's only used in udata-front-kit. In udata-front, we are only using the jinja version.

This update allows the component to be shown without the quality score warnings. It's required to make the same functionality as our jinja component (see ecolabdata/ecospheres#187).

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@nicolaskempf57 nicolaskempf57 merged commit 6624ee2 into datagouv:master Jun 11, 2024
8 checks passed
@nicolaskempf57 nicolaskempf57 deleted the feat/allow-quality-score-warning-to-be-hidden branch June 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants