Use @datagouv/vue-toaster #403
Open
+40
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the newly published @datagouv/vue-toaster (datagouv/data.gouv.fr#1317 for details).
This PR doesn't update udata-front to use the
useToastfrom the data.gouv.fr-component package. It isn't exported in the NPM version of the package right now. I think it's better to wait for our new release pipeline from master before doing it.Note
@datagouv/vue-toaster is moved from devDependencies to dependencies to help us distinguish dependencies used in udata-front, following #354. This is an ongoing process and all our dependencies aren't moved yet.
They aren't really needed in the production environment because the js is bundled before.