Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hydra] Refactor des routes hydra existantes #115

Closed
bolinocroustibat opened this issue Jul 31, 2024 · 1 comment · Fixed by #117
Closed

[hydra] Refactor des routes hydra existantes #115

bolinocroustibat opened this issue Jul 31, 2024 · 1 comment · Fixed by #117
Assignees
@bolinocroustibat
Labels
code quality Indique qu'il s'agit d'une amélioration de la qualité du code (au sens très large) nettoyage

Comments

@bolinocroustibat
Copy link
Contributor

Les routes hydra existantes sont peu RESTful et pas consistantes.
Les refactorer en gardant les anciennes routes en alias pour garder la compatibilité ?
@bolinocroustibat bolinocroustibat self-assigned this Jul 31, 2024
@bolinocroustibat bolinocroustibat mentioned this issue Jul 31, 2024
Merged
@bolinocroustibat
Copy link
Contributor Author

PR: #117

bolinocroustibat added a commit that referenced this issue Aug 1, 2024
@bolinocroustibat
refactor: refactor routes (#117)
4441611 
Closes #115

Refactor routes URL, routes handle names and routes files.

Existing hydra routes were not very RESTful and not consistent in terms
of URLs and methods. This PR refactors them, while keeping the old
routes working to keep retrocompatibility.
- Tests have been adapted to test both new routes and legacy routes
- #TODO flags has been added to flag legacy routes that can be removed
once they are not used anymore from any external service (udata)

One should make a new PR to clean legacy routes from hydra once udata will be modified to use the new routes.
@bolinocroustibat bolinocroustibat changed the title Refactor des routes hydra existantes [hydra] refactor des routes hydra existantes Aug 14, 2024
@bolinocroustibat bolinocroustibat changed the title [hydra] refactor des routes hydra existantes [hydra] Refactor des routes hydra existantes Aug 14, 2024
@bolinocroustibat bolinocroustibat added code quality Indique qu'il s'agit d'une amélioration de la qualité du code (au sens très large) nettoyage labels Aug 27, 2024
bolinocroustibat added a commit that referenced this issue Aug 27, 2024
@bolinocroustibat
refactor: refactor routes (#117)
f4a0340 
Closes #115

Refactor routes URL, routes handle names and routes files.

Existing hydra routes were not very RESTful and not consistent in terms
of URLs and methods. This PR refactors them, while keeping the old
routes working to keep retrocompatibility.
- Tests have been adapted to test both new routes and legacy routes
- #TODO flags has been added to flag legacy routes that can be removed
once they are not used anymore from any external service (udata)

One should make a new PR to clean legacy routes from hydra once udata will be modified to use the new routes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bolinocroustibat bolinocroustibat

Labels
code quality Indique qu'il s'agit d'une amélioration de la qualité du code (au sens très large) nettoyage
Projects
🚀 Produit data.gouv.fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: refactor routes datagouv/hydra
1 participant
@bolinocroustibat