Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4
Problem
there is a breaking change of datafusion v8
also original implementation "should not" call
bigtable.read_rows
during plan phaseexecute
. It should deferred to the return streamSolution
split original async method
execute
toexecute_query
and usefutures::stream::once
andRecordBatchStreamAdapter
to wrap it in plan phaseexecute
To reviewers
please review by commits. Datafusion 8 requires some change on ExecutionPlan, thus I split it to another file first