feat: experimental runtime bloom pruning #15382
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantengsky
changed the title
github-actions
bot
added
the
pr-feature
dantengsky
force-pushed
the
feat-rt-bloom
branch
2 times, most recently
from
fb634ab
to
b924e8a
Compare
Docker Image for PR
|
dantengsky
changed the title
dantengsky
force-pushed
the
feat-rt-bloom
branch
5 times, most recently
from
34cefb6
to
e9d6d67
Compare
dantengsky
added
ci-benchmark
Docker Image for PR
|
xudong963
approved these changes
May 9, 2024
|
@xudong963 Thanks for helping me review this PR; really appreciate it. Let me try to make further adjustments to avoid using the bloom filter in situations where false positives could nearly make bloom pruning ineffective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Implements runtime pruning for probe-side data blocks by utilizing the runtime filter (based on the min-max filter) and the bloom filter index of the probe table.
replace range filter expression with
eqfilter expressions if min equals max while constructing the min-max filtersthe
eqfilter expression is compatible with both rangeindex and bloom indexduring runtime filtering (of probe side data), if runtime min-max pruning failed, the bloom filter will be tried.
add new profile metric
RuntimeBloomFilterPrunedParts, which records the number of blocks pruned by bloom filterFixes #[Link the issue here]
Tests
Type of change
This change is