Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] refactor to clap.rs #1491

Merged
merged 5 commits into from
Aug 17, 2021
Merged

[CLI] refactor to clap.rs #1491

merged 5 commits into from
Aug 17, 2021

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Aug 17, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Refactor subcommands through clap and add integration tests to those commands

Changelog

  • Improvement

Related Issues

fixes #1475

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@ZhiHanZ ZhiHanZ requested a review from BohuTANG August 17, 2021 07:42
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #1491 (5f994dd) into master (518372f) will increase coverage by 0%.
The diff coverage is 78%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1491    +/-   ##
=======================================
  Coverage      73%     73%            
=======================================
  Files         512     512            
  Lines       30115   30433   +318     
=======================================
+ Hits        22045   22515   +470     
+ Misses       8070    7918   -152     
Impacted Files Coverage Δ
cli/src/cmds/packages/switch.rs 52% <51%> (+52%) ⬆️
cli/src/cmds/processor.rs 42% <75%> (+42%) ⬆️
cli/src/cmds/packages/fetch.rs 74% <81%> (+74%) ⬆️
cli/src/cmds/packages/package.rs 68% <83%> (+68%) ⬆️
cli/src/cmds/config.rs 100% <100%> (ø)
cli/src/cmds/packages/list.rs 94% <100%> (+94%) ⬆️
cli/src/cmds/status_test.rs 90% <100%> (ø)
cli/src/cmds/versions/version.rs 82% <100%> (+82%) ⬆️
store/src/meta_service/raftmeta.rs 80% <0%> (+<1%) ⬆️
store/src/meta_service/meta_service_impl.rs 57% <0%> (+1%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518372f...5f994dd. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit a4ed3be into master Aug 17, 2021
@databend-bot databend-bot deleted the clap branch August 17, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] Refactor CLI using clap command line tool
4 participants