Fabrica updates 4.x #874
Merged
Fabrica updates 4.x #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cli-htmlbars upgrade.
…e' validation to new 'inline-style'.
…ed into app/adapters/application.js)
…ssic until we can use the codemod to convert them all.
…-native-class-codemod)
…to prep for conversion to native javascript classes.
…-model-fragments addon.
…ly injected in routes/settings.js
…stall warnings - glob/glob-parent, yarn version)
…, page rendering was broken at BsNav due to old versions @ember/render-modifiers being used by several modules, glob version warnings in yarn install, updated yarn global install to latest version"
…data-model-fragments.
…s not a function'.
…map-concat via a resolution to get them back.
…h that returns no results.
…d providers when clicking the 'assign prefix' button.
…k blue when it used to be gray.
…k blue when it used to be gray.
…Was submitting on enter from power-select fields. This makes the behavior the same as the provider/edit form. Also, cleanup.
…undeleted) contacts.
…It caused 2 contacts to be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes: #761
Vercel preview: https://bracco-for4r3wfx-datacite.vercel.app/
Approach
Upgrade Fabrica to Ember v4.12, continue migration to Octane. (As outlined in The epic #761, see Fabric Ember Upgrade Technical Spec, and other documents listed there).
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix/version upgrade (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: