Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Fabrica form resets selected prefix when entering metadata #865

Merged
merged 3 commits into from
May 28, 2024

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented May 24, 2024

Purpose

Fix for Fabrica form resets selected prefix when entering metadata

closes: #864

Approach

Change didReceiveAttrs lifecycle hook to init so setDefaultPrefix is only called when the form loads.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Copy link
Contributor

@svogt0511 svogt0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the console.log unless there is a good reason for it. Otherwise, looks good.

Also, I see a test failure but I don't think it has anything to do with this change. Probably will pass if you run the suite again.

@codycooperross
Copy link
Contributor Author

Please remove the console.log unless there is a good reason for it. Otherwise, looks good.

Also, I see a test failure but I don't think it has anything to do with this change. Probably will pass if you run the suite again.

Thank you! My mistake—thought I had caught them all.

Copy link
Contributor

@svogt0511 svogt0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed timing on the test and it worked.

If you want to change what I did to the test, feel free to do so!

@codycooperross
Copy link
Contributor Author

Thank you! That test has gotten flakier, so this is a good fix.

@codycooperross codycooperross merged commit aed81a5 into main May 28, 2024
5 checks passed
@codycooperross codycooperross deleted the codycooperross/issue864 branch May 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering new metadata in Fabrica form resets selected prefix
2 participants