Skip to content

Commit

Permalink
Ember 3.16, Node 18 (cleanup).
Browse files Browse the repository at this point in the history
  • Loading branch information
svogt0511 committed Jun 20, 2023
1 parent 51f9d05 commit 11998f6
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
path: test_build/

- name: Cypress Testing
uses: cypress-io/github-action@v5.0.5
uses: cypress-io/github-action@v5
with:
config-file: cypress.config.ts
install: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
path: test_build/

- name: Cypress Testing
uses: cypress-io/github-action@v5.0.5
uses: cypress-io/github-action@v5
with:
config-file: cypress.config.ts
install: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
path: test_build/

- name: Cypress Testing
uses: cypress-io/github-action@v5.0.5
uses: cypress-io/github-action@v5
with:
config-file: cypress.config.ts
install: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
path: test_build/

- name: Cypress Testing
uses: cypress-io/github-action@v5.0.5
uses: cypress-io/github-action@v5
with:
config-file: cypress.config.ts
install: false
Expand Down
3 changes: 3 additions & 0 deletions app/components/repository-info.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ export default Component.extend({

let self = this;
promise.then(function(value) {
if (self.isDestroying || self.isDestroyed) {
return;
}
self.set('json', value);
}, function(reason) {
console.debug(reason);
Expand Down
Binary file not shown.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
"xml2js": "^0.4.23"
},
"engines": {
"node": "^14 || ^16 || ^18"
"node": "^18"
},
"ember": {
"edition": "classic"
Expand Down

0 comments on commit 11998f6

Please sign in to comment.