Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/RenamingClasses #47

Merged
merged 15 commits into from
Mar 18, 2021
Merged

Refactor/RenamingClasses #47

merged 15 commits into from
Mar 18, 2021

Conversation

JavierMonton
Copy link
Contributor

This PR aims to rename a few classes to:

  • Make them more understable
  • Add a complete guide on how to create a new type
  • Links .md files and expose them in GitHub Pages

@github-pages github-pages bot temporarily deployed to github-pages March 18, 2021 21:34 Inactive
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #47 (b7b0f72) into main (9916cad) will decrease coverage by 23.39%.
The diff coverage is 48.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##              main      #47       +/-   ##
============================================
- Coverage   100.00%   76.60%   -23.40%     
============================================
  Files           11       11               
  Lines          171      171               
  Branches         5        4        -1     
============================================
- Hits           171      131       -40     
- Misses           0       40       +40     
Flag Coverage Δ
unittests 76.60% <48.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tools/bigdatatypes/spark/SparkTypeConversion.scala 100.00% <ø> (ø)
...ls/bigdatatypes/bigquery/BigQueryDefinitions.scala 21.05% <7.69%> (-78.95%) ⬇️
...atatools/bigdatatypes/bigquery/BigQueryTable.scala 24.24% <8.33%> (-75.76%) ⬇️
.../bigdatatypes/bigquery/SqlInstanceToBigQuery.scala 100.00% <100.00%> (ø)
...ools/bigdatatypes/bigquery/SqlTypeToBigQuery.scala 100.00% <100.00%> (ø)
...rg/datatools/bigdatatypes/spark/SparkSchemas.scala 100.00% <100.00%> (ø)
.../datatools/bigdatatypes/spark/SqlTypeToSpark.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9916cad...b7b0f72. Read the comment docs.

@github-pages github-pages bot temporarily deployed to github-pages March 18, 2021 21:37 Inactive
@github-pages github-pages bot temporarily deployed to github-pages March 18, 2021 21:42 Inactive
@github-pages github-pages bot temporarily deployed to github-pages March 18, 2021 21:44 Inactive
@JavierMonton JavierMonton merged commit 6339d6e into main Mar 18, 2021
@JavierMonton JavierMonton deleted the Refactor/RenamingClasses branch April 6, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant