Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the behavior of clip() when one of the operands is nan #813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specify the behavior of clip() when one of the operands is nan #813

wants to merge 1 commit into from

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Jun 5, 2024

This follows the NumPy behavior, where the result is nan if any operand is nan. I checked PyTorch and it seems to do this as well.

rgommers
rgommers approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks very reasonable to me, thanks Aaron.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Jun 13, 2024
@rgommers rgommers added this to the v2024 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
v2024
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asmeurer @rgommers