feat!: rename "max rank" to "max dimensions" in capabilities()
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
LGTM. This change was discussed in workgroup meetings and was considered any improvement over the current state. And as no other suggestions for the rename were proposed, max dimensions wins out by default. Thanks, @asmeurer!
capabilities()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #763 (comment). "Rank" is an ambiguous term and "dimensions" is clearer. Although other names like "max ndims" would also be OK.
This is an unreleased API, and it's new in all implementations, so there should not be a concern with renaming it.