Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ALTER TABLE and ALTER SCHEMA #904

Merged
merged 8 commits into from
Dec 16, 2022
Merged

Add support for ALTER TABLE and ALTER SCHEMA #904

merged 8 commits into from
Dec 16, 2022

Conversation

charlesbluca
Copy link
Collaborator

Closes #884

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022 •
edited
Loading

Codecov Report

Merging #904 (545fcb0) into main (30716de) will increase coverage by 0.47%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   77.35%   77.82%   +0.47%     
==========================================
  Files          75       75              
  Lines        4230     4235       +5     
  Branches      771      772       +1     
==========================================
+ Hits         3272     3296      +24     
+ Misses        789      765      -24     
- Partials      169      174       +5
Impacted Files Coverage Δ
dask_sql/context.py 94.21% <50.00%> (+0.04%) ⬆️
dask_sql/physical/rel/custom/alter.py 90.00% <100.00%> (+52.96%) ⬆️
dask_sql/_version.py 35.31% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ayushdg
ayushdg approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm! Thanks a lot @charlesbluca.

Minor comment around the tests.

tests/unit/test_context.py Show resolved Hide resolved
@ayushdg ayushdg merged commit 4298d4d into dask-contrib:main Dec 16, 2022
@charlesbluca charlesbluca deleted the alter-table-schema branch March 19, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg ayushdg approved these changes

@andygrove andygrove Awaiting requested review from andygrove

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner

@jdye64 jdye64 Awaiting requested review from jdye64 jdye64 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Add back support for ALTER TABLE | SCHEMA
3 participants
@charlesbluca @codecov-commenter @ayushdg