Don't check order for filtered groupby test #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like changes in Dask have made the ordering of one of the results in
test_group_by_filtered
different, causing failures - this PR addscheck_index=False
to the relevant assertion, since maintaining a sorted ordering for groupbys wasn't a guarantee to begin with.Perhaps it would be worth thinking about if we want to make this a default kwarg for our
assert_eq
shim, considering we aren't concerned with ordering unless something like anORDER BY
statement is being tested (cc @ayushdg).Closes #701