Uncomment skipped rex pytests #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sql into datafusion-rex-pytest
…-sql into datafusion-rex-pytest
|
@ayushdg seems like this fixes several tests. Do you want to merge with upstream and have it reviewed now or want to work on it more to get all tests in |
I plan on triaging a few more tests and link to issues for those tests before marking this ready for review. |
jdye64
approved these changes
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## datafusion-sql-planner #661 +/- ##
=========================================================
Coverage ? 66.97%
=========================================================
Files ? 73
Lines ? 3637
Branches ? 753
=========================================================
Hits ? 2436
Misses ? 1055
Partials ? 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of the pr is to triage the currently skipped rex pytests and link to issues and or fix whatever is possible in the scope of this pr.