Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DF] Add support for DROP TABLE statements #658

Merged

Conversation

charlesbluca
Copy link
Collaborator

Depends on #656

@charlesbluca charlesbluca changed the base branch from main to datafusion-sql-planner August 3, 2022 18:54
@jdye64
Copy link
Collaborator

jdye64 commented Aug 3, 2022

Gonna wait on #656 before reviewing, if I forget poke me again =)

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (datafusion-sql-planner@c830cb5). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             datafusion-sql-planner     #658   +/-   ##
=========================================================
  Coverage                          ?   66.37%           
=========================================================
  Files                             ?       73           
  Lines                             ?     3637           
  Branches                          ?      754           
=========================================================
  Hits                              ?     2414           
  Misses                            ?     1074           
  Partials                          ?      149           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the change!

@jdye64 jdye64 merged commit 4b291ed into dask-contrib:datafusion-sql-planner Aug 8, 2022
@charlesbluca charlesbluca deleted the df-drop-table branch August 31, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants