Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting of literals is done by Calcite, except for strings #178

Merged
merged 2 commits into from
May 16, 2021

Conversation

nils-braun
Copy link
Collaborator

This PR fixes an issue with occurs due to this

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #178 (595efae) into main (e065161) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #178   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         2207      2209    +2     
  Branches       302       303    +1     
=========================================
+ Hits          2207      2209    +2     
Impacted Files Coverage Δ
dask_sql/physical/rex/core/call.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e065161...595efae. Read the comment docs.

@nils-braun nils-braun merged commit bbfee5f into main May 16, 2021
@nils-braun nils-braun deleted the bugfix/fix-string-casting branch May 16, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants