Move Dask config overrides to sql.yaml #1260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, many trivial SQL queries are failing due to Dask dataframe config defaults not being supported in Dask-SQL right now:
Currently, we're overriding the offending Dask config values in our pytest configuration, but it might make sense to bake those overrides into dask-sql's own Dask config file so that users don't have to make those overrides manually to get things working.