Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aliased column names for cross joins #1250

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charlesbluca
Copy link
Collaborator

@charlesbluca charlesbluca commented Oct 25, 2023

Because we were forgetting to alias/unalias column names before/after the merge operation, tables sharing column names were not being handled properly

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #1250 (df198d1) into main (3972967) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1250   +/-   ##
=======================================
  Coverage   85.55%   85.56%           
=======================================
  Files          77       77           
  Lines        4258     4260    +2     
  Branches      758      758           
=======================================
+ Hits         3643     3645    +2     
  Misses        446      446           
  Partials      169      169           
Files Coverage Δ
dask_sql/physical/rel/logical/cross_join.py 88.88% <100.00%> (+0.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants