Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory issues in Docker builds #1219

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

charlesbluca
Copy link
Collaborator

Looks like since merging #1181, we've been encountering some memory/resource pressure during our Docker builds that causes the GHA runs to cancel prematurely:

https://github.com/dask-contrib/dask-sql/actions/runs/5894517992/job/15988310016

Interested in if switching our installation process over to maturin develop and/or limiting the amount of CPUs being used for compilation could resolve things here

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #1219 (e954e94) into main (17c1d4e) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head e954e94 differs from pull request most recent head 18f21e7. Consider uploading reports for the commit 18f21e7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   81.58%   81.49%   -0.09%     
==========================================
  Files          78       78              
  Lines        4610     4610              
  Branches      854      854              
==========================================
- Hits         3761     3757       -4     
+ Misses        660      659       -1     
- Partials      189      194       +5     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charlesbluca charlesbluca merged commit a71b3eb into dask-contrib:main Aug 24, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants