Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fastapi dependency to >=0.92.0 #1205

Merged
merged 7 commits into from
Jul 29, 2023

Conversation

charlesbluca
Copy link
Collaborator

Doing this to avoid GHSA-3qj8-93xh-pwh2; interested in what needs to change to allow this

Comment on lines -8 to -9
# FIXME: handling is needed for httpx-based fastapi>=0.87.0
- fastapi>=0.69.0,<0.87.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more context, fastapi version 0.86.0 pins to starlette version 0.20.4, which was the last release before 0.87.0 (and so the latest version of fastapi allowed by this pin). Hence why the starlette installed has that CVE

Copy link
Contributor

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles! 🙏

Noticing the latest fastapi is causing more test failures than some of the older ones. We might consider keeping an upper bound, but just bumping that upper bound as well (based on whichever version causes the least issues)

That way we could then fix at most a handful of issues (or maybe just one)

Alternatively the issues in the newer version seem to repeat across tests. So maybe there is only one needed change to adapt to the newer versions of fastapi

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #1205 (c73881d) into main (af18062) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   82.13%   82.23%   +0.10%     
==========================================
  Files          78       78              
  Lines        4572     4572              
  Branches      849      849              
==========================================
+ Hits         3755     3760       +5     
+ Misses        634      625       -9     
- Partials      183      187       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jakirkham jakirkham marked this pull request as ready for review July 28, 2023 22:20
@jakirkham
Copy link
Contributor

Looks like this is now passing! 🎉

@jakirkham jakirkham merged commit 0c63447 into dask-contrib:main Jul 29, 2023
25 checks passed
@jakirkham
Copy link
Contributor

Thanks all! 🙏

Merging so we can get this fix out

Happy to follow up on anything else as needed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants