Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xz to conda host dependencies #1202

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

charlesbluca
Copy link
Collaborator

@charlesbluca charlesbluca commented Jul 19, 2023

This should resolve the overlink warnings we get during the linux-64 builds:

WARNING (dask-sql,lib/python3.10/site-packages/dask_planner/rust.cpython-310-x86_64-linux-gnu.so): Needed DSO lib/liblzma.so.5 found in ['xz']
WARNING (dask-sql,lib/python3.10/site-packages/dask_planner/rust.cpython-310-x86_64-linux-gnu.so): .. but ['xz'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

I've also added the --error-overlinking flag to the builds which should catch any potential overlink issues moving forward.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #1202 (a575d5c) into main (2c5a492) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   82.13%   82.23%   +0.10%     
==========================================
  Files          78       78              
  Lines        4572     4572              
  Branches      849      849              
==========================================
+ Hits         3755     3760       +5     
+ Misses        634      625       -9     
- Partials      183      187       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles! 🙏

@charlesbluca charlesbluca merged commit 6623597 into dask-contrib:main Jul 28, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants