Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for left semi and left anti joins #1182

Merged
merged 15 commits into from
Jun 30, 2023
Merged

Add support for left semi and left anti joins #1182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8d3f53b
Add beggining of support for left anti joins
Jun 14, 2023
4a8d9bf
Update for gpu
Jun 22, 2023
4129154
Add leftsemi test
Jun 22, 2023
41632c8
Workaround column mismatch and update tests for gpu
Jun 22, 2023
99c1d01
Add cpu implementation of leftanti
Jun 22, 2023
c7d3a85
Merge branch 'main' into leftanti
Jun 22, 2023
6d24824
Update xfail queries
Jun 22, 2023
652c346
Merge branch 'main' into leftanti
ayushdg Jun 23, 2023
5fd0d9c
Fix column renaming
Jun 26, 2023
b3da2b7
Reverse test changes
Jun 26, 2023
9bae4e0
Limit select_names in _compute_table_from_rel
charlesbluca Jun 27, 2023
21690db
Address reviews
Jun 28, 2023
448d5de
Revert type change
Jun 28, 2023
f6dba77
Update type annotations
ChrisJar Jun 30, 2023
5ab4b0c
Update imports in base.py
ChrisJar Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address reviews
  • Loading branch information
Chris Jarrett committed Jun 28, 2023
commit 21690db7e38a6333158ea1040452f8c6a13de360
4 changes: 2 additions & 2 deletions dask_sql/physical/rel/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def convert(self, rel: "LogicalPlan", context: "dask_sql.Context") -> dd.DataFra

@staticmethod
def fix_column_to_row_type(
cc: ColumnContainer, row_type: "RelDataType", join_type: str = None
cc: ColumnContainer, row_type: "RelDataType", join_type: str | None = None
) -> ColumnContainer:
"""
Make sure that the given column container
Expand Down Expand Up @@ -87,7 +87,7 @@ def assert_inputs(

@staticmethod
def fix_dtype_to_row_type(
dc: DataContainer, row_type: "RelDataType", join_type: str = None
dc: DataContainer, row_type: "RelDataType", join_type: str | None = None
):
"""
Fix the dtype of the given data container (or: the df within it)
Expand Down
3 changes: 2 additions & 1 deletion dask_sql/physical/rel/logical/join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ def convert(self, rel: "LogicalPlan", context: "dask_sql.Context") -> DataContai

join_type = join.getJoinType()
join_type = self.JOIN_TYPE_MAPPING[str(join_type)]
# TODO: update with correct implementation of leftsemi
# TODO: update with correct implementation of leftsemi for CPU
# https://github.com/dask-contrib/dask-sql/issues/1190
if join_type == "leftsemi" and not is_cudf_type(df_lhs_renamed):
join_type = "inner"

Expand Down
Loading