-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.8, add 3.11 & 3.12 to testing #1143
Conversation
A few more places we can update: dask-sql/dask_planner/Cargo.toml Line 16 in ab7340b
Line 42 in ab7340b
Can be done in a followup but we could remove a bunch of instances in the code for type hints with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
+ Coverage 85.55% 85.56% +0.01%
==========================================
Files 77 77
Lines 4258 4255 -3
Branches 758 794 +36
==========================================
- Hits 3643 3641 -2
+ Misses 446 445 -1
Partials 169 169 ☔ View full report in Codecov by Sentry. |
There are some intermittent mamba env solve failures I'm trying to work through (could be worth getting a minimal example together to open an issue in setup-miniconda), but seems like in general the main blocker here is lack of |
.github/workflows/release.yml
Outdated
# corresponds to python 3.9, 3.10, 3.11 | ||
python: ["9", "10", "11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an ideal world, we would be using the full python versions here, but since manipulation of string variables in GHA is difficult I think adding this comment to make things more easily grep-able is a fair compromise
Looks like the blockers now are lack of availability for I'll open a separate PR to address the issues around cibuildwheel, but not really sure what to do about the Hive testing - it seems like the GH page for diff --git a/tests/integration/test_hive.py b/tests/integration/test_hive.py
index 1a86082c..85ab763f 100644
--- a/tests/integration/test_hive.py
+++ b/tests/integration/test_hive.py
@@ -138,7 +138,7 @@ def hive_cursor():
"IPAddress"
]
port = 10000
- cursor = sqlalchemy.create_engine(f"hive:https://{address}:{port}").connect()
+ cursor = sqlalchemy.create_engine(f"hive:https://{address}:{port}", connect_args={"auth": "NOSASL"}).connect()
# Create a non-partitioned column
cursor.execute( |
Thanks for looking into this. Assuming sail cannot be patched in time for 3.11 we might want to evaluate skipping hive tests for 3.11. |
I think gpuCI should pass now after merging main. |
Going to guess that the issues in the conda build are caused by the recent release of |
With RAPIDS planning to drop python 3.8 support in 23.06 and discussion happening in dask/community#315 around Dask doing the same relatively soon, now seems like a good time to begin exploring dropping 3.8 support/testing ourselves.