Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime[ns, UTC] as understood type #103

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

nils-braun
Copy link
Collaborator

@nils-braun nils-braun commented Jan 3, 2021

Fixes #102

Timezone aware types are still a bit "underrepresented" in dask-sql... This PR at least fixes the issue, but there might be more things to check for in the future

@codecov-io
Copy link

codecov-io commented Jan 3, 2021

Codecov Report

Merging #103 (b5af1b6) into main (40ba2d1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         1460      1464    +4     
  Branches       201       203    +2     
=========================================
+ Hits          1460      1464    +4     
Impacted Files Coverage Δ
dask_sql/mappings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ba2d1...b5af1b6. Read the comment docs.

@nils-braun nils-braun merged commit a45deb1 into main Jan 6, 2021
@nils-braun nils-braun deleted the feature/timezone-aware-datetime branch January 6, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed read mapping datetime with timezone in postgresql
2 participants