Switch function names #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first time that I read this code:
```elixir
def validate(options, schema) do
case validate_options_with_schema_and_path(schema, options_schema()) do
```
and this one:
```elixir
defp validate_options_with_schema(opts, fun, path) when is_function(fun) do
validate_options_with_schema(opts, fun.(), path)
```
it confuse me a bit, on the first `validate_options_with_schema_and_path/2` I
don't see the path as argument, in the second block of code, I see that the
path is needed but the function name is `validate_options_with_schema`. So, my
best guest is that we should switch the function names and that's what I did
here.
|
Good call, thanks @milmazz :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time that I read this code:
and this one:
it confused me a bit, on the first
validate_options_with_schema_and_path/2I don't see the path as an argument, in the second block of code, I see that the path is needed but the function name isvalidate_options_with_schema. So, my best guess is that we should switch the function names and that's what I did here.