Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler warnings #4

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

Jajcus
Copy link
Contributor

@Jajcus Jajcus commented Sep 7, 2022

Fixes warnings:

pico-ssd1306/ssd1306.c: In function 'ssd1306_draw_line': > pico-ssd1306/ssd1306.c:151:14: warning: pointer targets in passing argument 1 of 'swap' differ in signedness [-Wpointer-sign]
151 | swap(&x1, &x2);

and:

/home/jajcus/Dropbox/Modular/pico/screen_test/pico-ssd1306/ssd1306.c:193:21: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
193 | if(line & 1 ==1)

Fixes warnings:

> pico-ssd1306/ssd1306.c: In function 'ssd1306_draw_line':
> pico-ssd1306/ssd1306.c:151:14: warning: pointer targets in passing argument 1 of 'swap' differ in signedness [-Wpointer-sign]
>   151 |         swap(&x1, &x2);

and:

> /home/jajcus/Dropbox/Modular/pico/screen_test/pico-ssd1306/ssd1306.c:193:21: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>   193 |             if(line & 1 ==1)
Copy link
Owner

@daschr daschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daschr daschr merged commit 9574de7 into daschr:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants