Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support offline mode with GitHubFileSystem and review of all filesystems offline handling #94

Open
jbfaden opened this issue Jan 14, 2024 · 0 comments

Comments

@jbfaden
Copy link
Member

jbfaden commented Jan 14, 2024

One of the original design features of the remote filesystems is that they would be able to support an offline mode where files within the cache could be used when the URL is not accessible. This has not been implemented uniformly for all filesystem types and review needs to be done. (This probably will require some sort of proxy to simulate filesystems being down, and I often find myself trying to do this sort of testing when filesystems actually do go down.)

The GitHub/GitLabs filesystem didn't have the timeout set on the first connection to the remote server, and when abbith was down, Bill discovered things would just hang. I've put in a timeout for the initial connection, and the "toString" message will report the offline status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant